> On Sep 21, 2021, at 4:21 AM, Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx> wrote:
>
> From: Chaitanya Kulkarni <kch@xxxxxxxxxx>
>
> The local variable q is used to pass it to the blk_queue_discard(). We
> can get away with using lo->lo_queue instead of storing in a local
> variable which is not used anywhere else.
>
> No functional change in this patch.
>
> Signed-off-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
> ---
> drivers/block/loop.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index fedb8d63b4c6..51c42788731a 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -480,12 +480,11 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
> * information.
> */
> struct file *file = lo->lo_backing_file;
> - struct request_queue *q = lo->lo_queue;
> int ret;
>
> mode |= FALLOC_FL_KEEP_SIZE;
>
> - if (!blk_queue_discard(q)) {
> + if (!blk_queue_discard(lo->lo_queue)) {
> ret = -EOPNOTSUPP;
> goto out;
> }
> --
> 2.29.0
>
Looks good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
