Re: [PATCH v3] loop: reduce the loop_ctl_mutex scope

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3] loop: reduce the loop_ctl_mutex scope
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 30 Aug 2021 09:13:50 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>, Tyler Hicks <tyhicks@xxxxxxxxxxxxxxxxxxx>, linux-block <linux-block@xxxxxxxxxxxxxxx>
In-reply-to: <cc5c215f-4b3b-94e9-560b-a02d0e23c97c@i-love.sakura.ne.jp>
References: <2642808b-a7d0-28ff-f288-0f4eabc562f7@i-love.sakura.ne.jp> <20210827184302.GA29967@lst.de> <73c53177-be1b-cff1-a09e-ef7979a95200@i-love.sakura.ne.jp> <20210828071832.GA31755@lst.de> <c5e509ec-2361-af25-ec73-e033b5b46ebb@i-love.sakura.ne.jp> <33a0a1e5-a79f-1887-6417-c5a81f58e47d@i-love.sakura.ne.jp> <cc5c215f-4b3b-94e9-560b-a02d0e23c97c@i-love.sakura.ne.jp>
User-agent: Mutt/1.5.17 (2007-11-01)

Hi Tetsuo,

this generally looks fine to me.  The only issue is that I remember is
that cmpxchg did historically not work on bool on all architectures.
I'm not sure if this has been fixed since.

Follow-Ups:
- Re: [PATCH v3] loop: reduce the loop_ctl_mutex scope
  - From: Christoph Hellwig

References:
- [PATCH] loop: replace loop_ctl_mutex with loop_idr_spinlock
  - From: Tetsuo Handa
- Re: [PATCH] loop: replace loop_ctl_mutex with loop_idr_spinlock
  - From: Christoph Hellwig
- Re: [PATCH] loop: replace loop_ctl_mutex with loop_idr_spinlock
  - From: Tetsuo Handa
- Re: [PATCH] loop: replace loop_ctl_mutex with loop_idr_spinlock
  - From: Christoph Hellwig
- Re: [PATCH] loop: replace loop_ctl_mutex with loop_idr_spinlock
  - From: Tetsuo Handa
- [PATCH v2] loop: reduce the loop_ctl_mutex scope
  - From: Tetsuo Handa
- [PATCH v3] loop: reduce the loop_ctl_mutex scope
  - From: Tetsuo Handa

Prev by Date: Re: [PATCH] block/mq-deadline: Speed up the dispatch of low-priority requests
Next by Date: [PATCH] blocK: move dd_queued() to fix defined but not used warning
Previous by thread: [PATCH v3] loop: reduce the loop_ctl_mutex scope
Next by thread: Re: [PATCH v3] loop: reduce the loop_ctl_mutex scope
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]