On Mon, Aug 09, 2021 at 08:55:16PM -0600, Jens Axboe wrote: > On 8/9/21 8:47 PM, Ming Lei wrote: > > On Mon, Aug 09, 2021 at 02:36:25PM -0600, Jens Axboe wrote: > >> On 8/4/21 9:35 PM, Ming Lei wrote: > >>> On Thu, Jul 29, 2021 at 11:42:26AM +0800, Ming Lei wrote: > >>>> When merging one bio to request, if they are discard IO and the queue > >>>> supports multi-range discard, we need to return ELEVATOR_DISCARD_MERGE > >>>> because both block core and related drivers(nvme, virtio-blk) doesn't > >>>> handle mixed discard io merge(traditional IO merge together with > >>>> discard merge) well. > >>>> > >>>> Fix the issue by returning ELEVATOR_DISCARD_MERGE in this situation, > >>>> so both blk-mq and drivers just need to handle multi-range discard. > >>>> > >>>> Reported-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx> > >>>> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> > >>> > >>> Hello Jens and Guys, > >>> > >>> Ping... > >> > >> Since this isn't a new regression this release and since this kind > >> of change always makes me a bit nervous, any objections to queueing > >> it up for 5.15 with the stable/fixes tags? > > > > Fine, will post a new version with fixes tag. > > Sorry if I wasn't clear, I mean are you fine with queueing this for > 5.15? I already did add the fixes tag. Sorry for misunderstanding your point, yeah, I am fine with queuing in 5.15. Thanks, Ming
