Re: [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/4/21 9:35 PM, Ming Lei wrote:
> On Thu, Jul 29, 2021 at 11:42:26AM +0800, Ming Lei wrote:
>> When merging one bio to request, if they are discard IO and the queue
>> supports multi-range discard, we need to return ELEVATOR_DISCARD_MERGE
>> because both block core and related drivers(nvme, virtio-blk) doesn't
>> handle mixed discard io merge(traditional IO merge together with
>> discard merge) well.
>>
>> Fix the issue by returning ELEVATOR_DISCARD_MERGE in this situation,
>> so both blk-mq and drivers just need to handle multi-range discard.
>>
>> Reported-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
>> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> 
> Hello Jens and Guys,
> 
> Ping...

Since this isn't a new regression this release and since this kind
of change always makes me a bit nervous, any objections to queueing
it up for 5.15 with the stable/fixes tags?

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux