Re: [PATCH] pd: fix order of cleaning up the queue and freeing the tagset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jens, can you pick this one up?

On Tue, Jul 06, 2021 at 09:07:34AM +0800, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@xxxxxxxxxx>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Signed-off-by: Guoqing Jiang <jiangguoqing@xxxxxxxxxx>
> ---
>  drivers/block/paride/pd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
> index 3b2b8e872beb..9b3298926356 100644
> --- a/drivers/block/paride/pd.c
> +++ b/drivers/block/paride/pd.c
> @@ -1014,8 +1014,8 @@ static void __exit pd_exit(void)
>  		if (p) {
>  			disk->gd = NULL;
>  			del_gendisk(p);
> -			blk_mq_free_tag_set(&disk->tag_set);
>  			blk_cleanup_disk(p);
> +			blk_mq_free_tag_set(&disk->tag_set);
>  			pi_release(disk->pi);
>  		}
>  	}
> -- 
> 2.25.1
> 
---end quoted text---



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux