Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jens, can you pick this up?

On Tue, Jul 06, 2021 at 12:00:16PM +0800, Guoqing Jiang wrote:
> From: Wang Qing <wangqing@xxxxxxxx>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
> Signed-off-by: Guoqing Jiang <jiangguoqing@xxxxxxxxxx>
> ---
> V2 changes: Correct the fixes tag and mail address.
> 
>  drivers/block/nbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index b7d663736d35..c38317979f74 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)
>  
>  	if (disk) {
>  		del_gendisk(disk);
> -		blk_mq_free_tag_set(&nbd->tag_set);
>  		blk_cleanup_disk(disk);
> +		blk_mq_free_tag_set(&nbd->tag_set);
>  	}
>  
>  	/*
> -- 
> 2.25.1
> 
---end quoted text---



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux