On 3/7/21 8:26 PM, Oleksandr Natalenko wrote:
Hmmm NACK.
CFQ and BFQ are completely different beasts.
If you are going to tune BFQ to match old CFQ behaviour (somehow; I
don't know why one would do this, how one would do this and whether it
is possible at all), you for sure have enough time to fix your old udev
rules and scripts.
If you are just tolerating default BFQ behaviour, you should explicitly
acknowledge it by amending your rules and scripts. For personal systems
this is not a big deal. For enterprise systems you better do it NOW so
that another person that comes to work on those systems in 10 years
after you resign knows what and why was done.
If you are just lazy (no offence! I don't know your real intention
here), I'm not sure we are going to hide such an indifference behind
another aliasing kludge.
Thanks.
You are writing a lot, and say nothing.
bfq is the natural choice coming from cfq. There is NO other option.
Still waiting... for a valid *technical* response against my change.
Or do you prefer to apply the below patch?.
---cortamorena---
From 714f04d823085a1aebbdc66dad2344c2aee9fdf3 Mon Sep 17 00:00:00 2001
From: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
Date: Wed, 24 Mar 2021 22:30:46 +0100
Subject: [PATCH] Revert "mq-deadline: add 'deadline' as a name alias"
X-Patchwork-Bot: notify
This reverts commit 4d740bc9f0319229410d11e445017f47e425dbe0.
_commit 4d740bc9f0319229410d11e445017f47e425dbe0
_Author: Jens Axboe <axboe@xxxxxxxxx>
_Date: Wed Oct 25 09:47:20 2017 -0600
_mq-deadline: add 'deadline' as a name alias
_The scheduler framework now supports looking up the appropriate
_scheduler with the {name,mq} tupple. We can register mq-deadline
_with the alias of 'deadline', so that switching to 'deadline'
_will do the right thing based on the type of driver attached to
_it.
_Reviewed-by: Omar Sandoval <osandov@xxxxxx>
_Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Cc: Omar Sandoval <osandov@xxxxxx>
Cc: Paolo Valente <paolo.valente@xxxxxxxxxx>
Cc: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
Cc: BLOCK ML <linux-block@xxxxxxxxxxxxxxx>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
---
block/mq-deadline.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/mq-deadline.c b/block/mq-deadline.c
index f3631a287466..91c9757451b3 100644
--- a/block/mq-deadline.c
+++ b/block/mq-deadline.c
@@ -795,7 +795,6 @@ static struct elevator_type mq_deadline = {
#endif
.elevator_attrs = deadline_attrs,
.elevator_name = "mq-deadline",
- .elevator_alias = "deadline",
.elevator_features = ELEVATOR_F_ZBD_SEQ_WRITE,
.elevator_owner = THIS_MODULE,
};
--
2.30.2
---fin---
Thank you.
