Hi.
On Sat, Mar 06, 2021 at 11:46:31PM +0100, Xose Vazquez Perez wrote:
>
> Avoid break old scrips and udev rules.
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 95586137194e..8c6c82860a45 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -6914,6 +6914,7 @@ static struct elevator_type iosched_bfq_mq = {
> .icq_align = __alignof__(struct bfq_io_cq),
> .elevator_attrs = bfq_attrs,
> .elevator_name = "bfq",
> + .elevator_alias = "cfq",
> .elevator_owner = THIS_MODULE,
> };
> MODULE_ALIAS("bfq-iosched");
Hmmm NACK.
CFQ and BFQ are completely different beasts.
If you are going to tune BFQ to match old CFQ behaviour (somehow; I
don't know why one would do this, how one would do this and whether it
is possible at all), you for sure have enough time to fix your old udev
rules and scripts.
If you are just tolerating default BFQ behaviour, you should explicitly
acknowledge it by amending your rules and scripts. For personal systems
this is not a big deal. For enterprise systems you better do it NOW so
that another person that comes to work on those systems in 10 years
after you resign knows what and why was done.
If you are just lazy (no offence! I don't know your real intention
here), I'm not sure we are going to hide such an indifference behind
another aliasing kludge.
Thanks.
--
Oleksandr Natalenko (post-factum)
