On Tue, Mar 9, 2021 at 10:54 PM Christoph Hellwig <hch@xxxxxx> wrote: > > Looks good to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Question on the pre-existing code: given that nvdimm_check_and_set_ro is > the only caller of set_disk_ro for nvdimm devices, we'll also get > the message when initially setting up any read-only disk. Is that > intentional? Yeah, that's intentional. There's no other notification that userspace would be looking for by default besides the kernel log, and the block device name is more meaningful than the region name, or the nvdimm device status for that matter.
