Looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> Question on the pre-existing code: given that nvdimm_check_and_set_ro is the only caller of set_disk_ro for nvdimm devices, we'll also get the message when initially setting up any read-only disk. Is that intentional?