On Sun 10-01-21 10:20:19, Paolo Valente wrote: > > > > Il giorno 9 apr 2020, alle ore 19:09, Jan Kara <jack@xxxxxxx> ha scritto: > > > > Currently queues that have average think time shorter than slice_idle > > cannot have waker. However this requirement is too strict. E.g. dbench > > process always submits a one or two IOs (which is enough to pull its > > average think time below slice_idle) and then blocks waiting for jbd2 > > thread to commit a transaction. Due to idling logic jbd2 thread is > > often forced to wait for dbench's idle timer to trigger to be able to > > submit its IO and this severely delays the overall benchmark progress. > > > > E.g. on my test machine current dbench single-thread throughput is ~80 > > MB/s, with this patch it is ~200 MB/s. > > > > Hi Jan, > I've modified this logic a little bit (in patches that I'm going to > submit). And I don't see your boost in my tests. So it's difficult > for me to validate this change. If ok for you, you could test it on > top of the patches that I'll submit. If you see a boost, and (as I > expect) I won't see any regression, this improvement is very welcome > for me. As I wrote in the cover letter, I'm not really convinced that patch conceptually makes sence. What you later implemented should be definitely a more sophisticated approach to the problem. So I'd just discard this patch. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
