On Wed 13-01-21 14:09:33, Jan Kara wrote: > On Sun 10-01-21 10:20:22, Paolo Valente wrote: > > > > > > > Il giorno 9 apr 2020, alle ore 19:09, Jan Kara <jack@xxxxxxx> ha scritto: > > > > > > The check in bfq_select_queue() checking whether a waker queue should be > > > selected has a bug and is checking bfqq->next_rq instead of > > > bfqq->waker_bfqq->next_rq to verify whether the waker queue has a > > > request to dispatch. This often results in the condition being false > > > (most notably when the current queue is idling waiting for next request) > > > and thus the waker queue logic is ineffective. Fix the condition. > > > > > > > Hi Jan, > > my huge delay causes problems again, because a student of mine already > > made this same fix a few months ago. But I did not send it out yet, > > for lack of time. If ok for you, we could go for a common commit with > > two authors (I seem to remember it is feasible). > > No problem for me. Or just give the student a credit instead of me. A > commit in the kernel is likely more interesting for him than for me ;) Just > reply to the v2 series I've sent today (you should be on CC) so that Jens > knows the author should be changed. Oh, this is a different patch than I thought. I didn't resubmit this one. Nevertheless "I don't care" still holds :). Just submit whatever you find fit. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
