Yes, Reject the device is the right fix. I will try to send another fix. By the way, I think this fix is good protection, maybe some other devices violate this block size constraint. Divide zero is unacceptable. Thanks, Feng Li Martin K. Petersen <martin.petersen@xxxxxxxxxx> 于2021年1月13日周三 上午1:48写道： > > > Johannes, > > >> I use the nvme-tcp as the host, the target is spdk nvme-tcp target, > >> and set a wrong block size(i.g. bs=8), then the host prints this oops: > > > > I think the better fix here is to reject devices which report a block size > > small than a sector. > > Yep, Linux doesn't support logical block sizes < 512 bytes. > > Also, the NVMe spec states: > > "A value smaller than 9 (i.e., 512 bytes) is not supported." > > -- > Martin K. Petersen Oracle Linux Engineering
