On Fri, Dec 04, 2020 at 03:20:40AM +0000, Chaitanya Kulkarni wrote: > On 12/2/20 01:10, Christoph Hellwig wrote: > > On Tue, Dec 01, 2020 at 10:22:23PM -0800, Chaitanya Kulkarni wrote: > >> Update the nvmet_execute_identify() such that it can now handle > >> NVME_ID_CNS_CS_CTRL when identify.cis is set to ZNS. This allows > >> host to identify the support for ZNS. > > The changs in this and all following patches really belong into the current > > patch 2. > > > > This and each following patch doing one specific thing for which host > > side component is responsible, with one patch for backend handlers and > > wiring up of the same on for admin-cmd.c and io-cmd-bdev.c seems > > we are packing too much into one, unlike what we have has a nice > > bottom-up flow for the implementation, why not we keep that nice flow ? Patches should do one thing at time. With this series patch 2 is very incomplete, which makes both review and later reading the commit history very hard.
