On 9/18/20 9:54 PM, yangerkun wrote: > 'f5bbbbe4d635 ("blk-mq: sync the update nr_hw_queues with > blk_mq_queue_tag_busy_iter")' introduce a bug what we may sleep between > rcu lock. Then '530ca2c9bd69 ("blk-mq: Allow blocking queue tag iter > callbacks")' fix it by get request_queue's ref. And 'a9a808084d6a ("block: > Remove the synchronize_rcu() call from __blk_mq_update_nr_hw_queues()")' > remove the synchronize_rcu in __blk_mq_update_nr_hw_queues. We need > update the confused comments in blk_mq_queue_tag_busy_iter. Applied, thanks. -- Jens Axboe