On Tue, Jul 07, 2020 at 07:37:41AM +0100, John Garry wrote: > On 06/07/2020 15:41, Ming Lei wrote: > > - hctx = flush_rq->mq_hctx; > > if (!q->elevator) { > > Is there a specific reason we do: > > if (!a) > do x > else > do y > > as opposed to: > > if (a) > do y > else > do x > > Do people find this easier to read or more obvious? Just wondering. If you like the style, please go ahead to switch to this way. The check on 'q->elevator' isn't added by this patch, and it won't be this patch's purpose at all. Thanks, Ming