On Wed, Jul 01, 2020 at 04:38:06AM +0000, Chaitanya Kulkarni wrote: > On 6/29/20 10:12 PM, Christoph Hellwig wrote: > > On Mon, Jun 29, 2020 at 04:43:10PM -0700, Chaitanya Kulkarni wrote: > >> Now that we have done cleanup we can safely get rid of the > >> blk_trace_request_get_cgid() and replace it with > >> blk_trace_bio_get_cgid(). > > To me the helper actually looks useful compared to open coding the > > check in a bunch of callers. > > > > The helper adds an additional function call which can be avoided easily > since blk_trace_bio_get_cgid() is written nicely, that also maintains > the readability of the code. > > Unless the cost of the function call doesn't matter and readability is > not lost can we please not use helper ? I think readability is lost. I'd much rather drop the q argument from blk_trace_request_get_cgid and keep the helper, as it pretty clearly documents what is done.
