Re: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
Subject: Re: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 30 Jun 2020 07:12:02 +0200
Cc: linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, jack@xxxxxxxx, rdunlap@xxxxxxxxxxxxx, sagi@xxxxxxxxxxx, mingo@xxxxxxxxxx, rostedt@xxxxxxxxxxx, snitzer@xxxxxxxxxx, agk@xxxxxxxxxx, axboe@xxxxxxxxx, paolo.valente@xxxxxxxxxx, ming.lei@xxxxxxxxxx, bvanassche@xxxxxxx, fangguoju@xxxxxxxxx, colyli@xxxxxxx, hch@xxxxxx
In-reply-to: <20200629234314.10509-8-chaitanya.kulkarni@wdc.com>
References: <20200629234314.10509-1-chaitanya.kulkarni@wdc.com> <20200629234314.10509-8-chaitanya.kulkarni@wdc.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Jun 29, 2020 at 04:43:10PM -0700, Chaitanya Kulkarni wrote:
> Now that we have done cleanup we can safely get rid of the
> blk_trace_request_get_cgid() and replace it with
> blk_trace_bio_get_cgid().

To me the helper actually looks useful compared to open coding the
check in a bunch of callers.

Follow-Ups:
- Re: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
  - From: Chaitanya Kulkarni

References:
- [PATCH 00/10] block: blktrace framework cleanup
  - From: Chaitanya Kulkarni
- [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
  - From: Chaitanya Kulkarni

Prev by Date: Re: [PATCH 05/11] block: get rid of the trace rq insert wrapper
Next by Date: Re: [PATCH 08/11] block: fix the comments in the trace event block.h
Previous by thread: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
Next by thread: Re: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]