Keith,
> diff --git a/drivers/block/null_blk_zoned.c b/drivers/block/null_blk_zoned.c
> index 624aac09b005..b05832eb21b2 100644
> --- a/drivers/block/null_blk_zoned.c
> +++ b/drivers/block/null_blk_zoned.c
> @@ -28,7 +28,17 @@ int null_init_zoned_dev(struct nullb_device *dev, struct request_queue *q)
> return -EINVAL;
> }
>
> + if (!dev->zone_capacity)
> + dev->zone_capacity = dev->zone_size;
> +
> + if (dev->zone_capacity > dev->zone_size) {
> + pr_err("null_blk: zone capacity %lu more than its size %lu\n",
> + dev->zone_capacity, dev->zone_size);
> + return -EINVAL;
> + }
Minor nit. I found the the error message hard to grok. Maybe something
like:
"null_blk: zone capacity (%lu MB) larger than zone size (%lu MB)\n"
Otherwise this looks fine.
Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
--
Martin K. Petersen Oracle Linux Engineering
