On Tue, Jun 16, 2020 at 08:34:21AM +0900, Keith Busch wrote:
> From: Aravind Ramesh <aravind.ramesh@xxxxxxx>
>
> Allow emulation of a zoned device with a per zone capacity smaller than
> the zone size as as defined in the Zoned Namespace (ZNS) Command Set
> specification. The zone capacity defaults to the zone size if not
> specified and must be smaller than the zone size otherwise.
>
> Signed-off-by: Aravind Ramesh <aravind.ramesh@xxxxxxx>
Just a little nitpick.
Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
> ---
> drivers/block/null_blk.h | 2 ++
> drivers/block/null_blk_main.c | 9 ++++++++-
> drivers/block/null_blk_zoned.c | 17 +++++++++++++++--
> 3 files changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/null_blk.h b/drivers/block/null_blk.h
> index 81b311c9d781..7eadf190528c 100644
> --- a/drivers/block/null_blk.h
> +++ b/drivers/block/null_blk.h
> @@ -44,11 +44,13 @@ struct nullb_device {
> unsigned int nr_zones;
> struct blk_zone *zones;
> sector_t zone_size_sects;
> + sector_t zone_capacity_sects;
>
> unsigned long size; /* device size in MB */
> unsigned long completion_nsec; /* time in ns to complete a request */
> unsigned long cache_size; /* disk cache size in MB */
> unsigned long zone_size; /* zone size in MB if device is zoned */
> + unsigned long zone_capacity; /* zone cap in MB if device is zoned */
Maybe also use zone capacity in the comment instead of the abbreviation?
