On 2020-05-20 10:06, Christoph Hellwig wrote: > The bio argument is entirely unused, and the request_queue can be passed > through the alloc_data, given that it needs to be filled out for the > low-level tag allocation anyway. Also rename the function to > __blk_mq_alloc_request as the switch between get and alloc in the call > chains is rather confusing. I think there are three changes in this patch (remove 'bio' argument, pass request queue pointer through struct blk_mq_alloc_data instead of as an argument and rename 'alloc_data' into 'data') which makes this patch harder to read than necessary. Additionally, I like the old name "alloc_data" better than the new name "data". Anyway: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
