Re: [PATCH] blkcg: Fix memory leak in blkg_conf_prep()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020/5/15 23:08, Markus Elfring wrote:
new_blkg = blkg_alloc(pos, q, GFP_KERNEL);
…

I suggest to omit the source code quotation from the change description.


if calling blkg_lookup_check() failed, at the IS_ERR block,
the new_blkg should be free before goto lable fail_unlock
in blkg_conf_prep() function.

How do you think about a wording variant like the following?

   If a call of the function “blkg_lookup_check” failed,
   release the previously allocated block group before jumping
   to the target “fail_unlock” in the implementation of
   the function “blkg_conf_prep”.


Thanks for your suggestion. omit the source code quotation from the description is more friendly. I will modify the description in V2 patch.

Thanks,
Wu Bo


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux