Re: [PATCH 9/9] blk-mq: drain I/O when all CPUs in a hctx are offline

[John Garry <john.garry@xxxxxxxxxx>]

On 18/05/2020 07:39, Christoph Hellwig wrote:
> +
>   /*
>    * 'cpu' is going away. splice any existing rq_list entries from this

Do we need to fix up this comment again?

Cheers,
John

>    * software queue to the hw queue dispatch list, and ensure that it
> @@ -2296,6 +2382,9 @@ static int blk_mq_hctx_notify_dead(unsigned int cpu, struct hlist_node *node)
>   	enum hctx_type type;
>   
>   	hctx = hlist_entry_safe(node, struct blk_mq_hw_ctx, cpuhp_dead);
> +	if (!cpumask_test_cpu(cpu, hctx->cpumask))
> +		return 0;
> +
>   	ctx = __blk_mq_get_ctx(hctx->queue, cpu);
>   	type = hctx->type;