Re: [PATCH 2/5] bio.h: Declare the arguments of bio iteration functions const

[Bart Van Assche <bvanassche@xxxxxxx>]

On 2020-05-16 01:55, Alexander Potapenko wrote:
> On Sat, May 16, 2020 at 2:19 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>> -static inline void bio_advance_iter(struct bio *bio, struct bvec_iter *iter,
>> -                                   unsigned bytes)
>> +static inline void bio_advance_iter(const struct bio *bio,
>> +                                   struct bvec_iter *iter, unsigned bytes)
>>  {
>>         iter->bi_sector += bytes >> 9;
>
> On a related note, should this 9 be SECTOR_SHIFT?

Hi Alexander,

I think a patch series is already under review for replacing "9" with
SECTOR_SHIFT. See also
https://lore.kernel.org/linux-block/20200507075100.1779-1-thunder.leizhen@xxxxxxxxxx/.

Thanks,

Bart.