Bart, > The above change looks confusing to me. We want the NVMe driver to set > io_opt, so why only call blk_queue_io_opt() if io_opt != 0? That means > that the io_opt value will be left to any value set by the block layer > core if io_opt == 0 instead of properly being set to zero. We do explicitly set it to 0 when allocating a queue. But no biggie. -- Martin K. Petersen Oracle Linux Engineering