Damien, > results in blk_stack_limits() to return an error when the combined > devices have different but compatible physical sector sizes (e.g. 512B > sector SSD with 4KB sector disks). We'll need to get that stacking logic fixed up to take io_opt into account when scaling pbs/min. Just as a safety measure in case we don't catch devices reporting crazy values in the LLDs. > Fix this by not setting the optiomal IO size limit if the namespace optimal > does not report an optimal write size value. Setting io_opt to the logical block size in the NVMe driver is equivalent to telling the filesystems that they should not submit I/Os larger than one sector. That makes no sense. This change is correct. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering
