On Wed, May 13, 2020 at 06:01:00AM -0700, Christoph Hellwig wrote: > Btw, with the many arguments an more beeing added later I'm not sure blk_mq_handle_partial_dispatch() is always inlined, and each parameter has precise meaning, so IMO more parameters shouldn't be an issue. > anymore if this is really worth a separate function or just if goto > label at the end of blk_mq_dispatch_rq_list that can be jumped to, > and which has the same amount of indentation is the better idea. > There are more benefits in this way: 1) blk_mq_dispatch_rq_list() becomes more readable 2) name of blk_mq_handle_partial_dispatch() has document benefit. 3) it is easier to add new code into both blk_mq_dispatch_rq_list() and blk_mq_handle_partial_dispatch(), same with changes on both two functions. 4) easier to verify/review two small function So IMO it is worth a separate function, especially blk_mq_dispatch_rq_list() is becoming a big monster function. Thanks, Ming
