On Wed, May 13, 2020 at 04:36:21PM -0500, Tony Asleson wrote: > +static int dev_to_nvme_durable_name(const struct device *dev, char *buf, size_t len) > +{ > + char serial[128]; > + ssize_t serial_len = wwid_show((struct device *)dev, NULL, serial); wwid_show() can generate a serial larger than 128 bytes. > + > + if (serial_len > 0 && serial_len < len) { > + serial_len -= 1; // Remove the '\n' from the string Comments in this driver should use the /* */ style. > + strncpy(buf, serial, serial_len); > + return serial_len; > + } > + return 0; > +}