On Wed, May 13, 2020 at 12:02:10PM +0000, Johannes Thumshirn wrote: > I know success handling is discouraged in the kernel, but I think > > rq = blk_mq_get_request(q, NULL, &alloc_data); > if (rq) > return rq; > > out_queue_exit: > blk_queue_exit(q); > return ERR_PTR(ret); > > looks nicer, doesn't it? Not at all. A flow of most common case stays in line, everything else jumps out really helps with reading.
