Re: [PATCH V2 4/4] block: don't hold part0's refcount in IO path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 08, 2020 at 03:41:57PM +0800, Ming Lei wrote:
> On Thu, May 07, 2020 at 11:41:33PM -0700, Christoph Hellwig wrote:
> > On Fri, May 08, 2020 at 12:44:07PM +0800, Ming Lei wrote:
> > > gendisk can't be gone when there is IO activity, so not hold
> > > part0's refcount in IO path.
> > > 
> > > Cc: Yufen Yu <yuyufen@xxxxxxxxxx>
> > > Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> > > Cc: Hou Tao <houtao1@xxxxxxxxxx>
> > > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> > 
> > This looks correct, although I'd still prefer to centralize the
> > partno checks in the helpers.  Also hd_struct_get is unused with
> > this patch isn't it?
>  
> OK, are you fine with the following patch?

Yes, this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux