On Fri, May 08, 2020 at 12:44:07PM +0800, Ming Lei wrote: > gendisk can't be gone when there is IO activity, so not hold > part0's refcount in IO path. > > Cc: Yufen Yu <yuyufen@xxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Cc: Hou Tao <houtao1@xxxxxxxxxx> > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> This looks correct, although I'd still prefer to centralize the partno checks in the helpers. Also hd_struct_get is unused with this patch isn't it?