On Fri, Apr 24, 2020 at 12:44:58PM +0200, Christoph Hellwig wrote: > > + /* avoid allocation failure by clearing NOWAIT */ > > + nrq = blk_get_request(rq->q, rq->cmd_flags & ~REQ_NOWAIT, flags); > > + if (!nrq) > > + return; > > + > > + blk_rq_copy_request(nrq, rq); > > + > > + nrq->timeout = rq->timeout; > > Shouldn't the timeout also go into blk_rq_copy_request? I'd suggest to not do it because dm-rq clones request between two different queues, and different queue may have different default timeout value. And I guess that is why dm-rq code doesn't do that. Thanks, Ming
