On Fri, Apr 24, 2020 at 12:42:38PM +0200, Christoph Hellwig wrote:
> > +static int blk_mq_hctx_notify_dead(unsigned int cpu, struct hlist_node *node)
> > +{
> > + struct blk_mq_hw_ctx *hctx = hlist_entry_safe(node,
> > + struct blk_mq_hw_ctx, cpuhp_dead);
> > +
> > + if (!cpumask_test_cpu(cpu, hctx->cpumask))
> > + return 0;
> > +
> > + blk_mq_hctx_handle_dead_cpu(hctx, cpu);
> > return 0;
>
> As commented last time:
>
> why not simply:
>
> if (cpumask_test_cpu(cpu, hctx->cpumask))
> blk_mq_hctx_handle_dead_cpu(hctx, cpu);
> return 0;
Hammm, it is just done on another handler, looks this one is missed.
Thanks,
Ming
