On Thu, Apr 09, 2020 at 08:02:59PM -0700, Bart Van Assche wrote: > On 2020-04-09 14:45, Luis Chamberlain wrote: > > if (si->bdev) { > > + bdev = bdgrab(si->bdev); > > + if (!bdev) > > + continue; > > + /* > > + * By adding our own bdgrab() we ensure the queue > > + * sticks around until disk_release(), and so we ensure > > + * our release of the request_queue does not happen in > > + * atomic context. > > + */ > > blkcg_schedule_throttle(bdev_get_queue(si->bdev), > > true); > > How about changing the si->bdev argument of blkcg_schedule_throttle() > into bdev? Sure, thanks! Luis