On 3/27/20 10:17 AM, Christoph Hellwig wrote: > On Fri, Mar 27, 2020 at 09:53:16AM -0600, Jens Axboe wrote: >> On 3/27/20 2:30 AM, Christoph Hellwig wrote: >>> Hi Jens, >>> >>> this series ensures all allocated queues have a valid ->make_request_fn >>> and also nicely consolidates the code for allocating queues. >> >> This seems fine to me, but might be a good idea to shuffle 4/5 as the >> last one, and do that one inside the merge window to avoid any potential >> silly merge conflicts. > > they should be trivial to reorder if you want to skip patch 4 for now. > But looking at current linux-next there isn't any conflict yet, > and I don't expect one as most block drivers go through the block > tree anyway. Yeah I guess so, and any potential conflict would be trivial. I'll apply it and hope for the best. -- Jens Axboe