On 02/11/2020 02:00 PM, Omar Sandoval wrote: >> fi > It's not in the git diff context, but the line above is > > if [ $# -eq 5 ] && [ -f ${cfs_path}/attr_cntlid_min ]; then > > So if we pass 6 arguments, the cntlid arguments are ignored? These > checks should probably be -ge > With the -ge change it will also print wrong skip reason for 034 I remember now I think that is the reason why kept it -eq :- Here is with -ge :- blktests (master) # ./check tests/nvme/033 nvme/033 (Test NVMeOF target cntlid[min|max] attributes) [not run] attr_cntlid_[min|max] not found blktests (master) # ./check tests/nvme/034 nvme/034 (Test NVMeOF target model attribute) [not run] attr_cntlid_[min|max] not found With -eq :- blktests (master) # ./check tests/nvme/033 nvme/033 (Test NVMeOF target cntlid[min|max] attributes) [not run] attr_cntlid_[min|max] not found blktests (master) # ./check tests/nvme/034 nvme/034 (Test NVMeOF target model attribute) [not run] attr_model not found