On Wed, Jan 29, 2020 at 03:29:19PM -0800, Chaitanya Kulkarni wrote:
> This patch updates helper function create_nvmet_subsystem() to handle
> newly introduced model attribute.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
> ---
> tests/nvme/rc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index d1fa796..377c7f7 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -123,6 +123,7 @@ _create_nvmet_subsystem() {
> local uuid=$3
> local cntlid_min=$4
> local cntlid_max=$5
> + local model=$6
> local cfs_path="${NVMET_CFS}/subsystems/${nvmet_subsystem}"
>
> mkdir -p "${cfs_path}"
> @@ -133,6 +134,9 @@ _create_nvmet_subsystem() {
> echo ${cntlid_min} > ${cfs_path}/attr_cntlid_min
> echo ${cntlid_max} > ${cfs_path}/attr_cntlid_max
> fi
It's not in the git diff context, but the line above is
if [ $# -eq 5 ] && [ -f ${cfs_path}/attr_cntlid_min ]; then
So if we pass 6 arguments, the cntlid arguments are ignored? These
checks should probably be -ge
> + if [ $# -eq 6 ] && [ -f ${cfs_path}/attr_model ]; then
> + echo ${model} > ${cfs_path}/attr_model
> + fi
More shellcheck warnings about unquoted variables.
> }
>
> _remove_nvmet_ns() {
> --
> 2.22.1
>
