> > > Please no vertical alignment in new code, it adds a lot of churn if such > > > line is changed later and creates difficulties for the backports. > > It does look nicer when it can be aligned. I don't get why backport is > > an argument here. > > The backport thing will be problematic once some fix is needed which > will require addition of extra variable. > > Imagine such situation, where you will need to add such variable. > > struct rnbd_clt_dev *dev = rq->rq_disk->private_data; > struct rnbd_clt_session *sess = dev->sess; > + struct rnbd_clt_session *sess_very_long_variable = ....; > > You will need to update vertical alignment for all variables and it > can create huge churn out of nowhere. The standard approach is to > avoid vertical space alignments from the beginning. Thanks for the explanation, I get your points now, but in that case, you can also choose a not so long name to keep the alignment. Even you have no choice for a shorter name, breaking the alignment is the last thing we have to worry about.
