On Tue, Dec 03, 2019 at 04:34:08PM +0100, Javier González wrote: > Agree on the BUG_ON part. But since you’re looking into this part now, would it make sense to do the check in the block layer only if the driver imposes a power of two? We can also do it down the road, but seems like double work. The whole block layer chunk / zone handling has always assumed power of two zone sizes. Changing that would introduce expensive divisions in the fast path. This patch just moves the check to where it belongs.