On Tue, Dec 03, 2019 at 03:00:09PM +0100, Javier González wrote: >> This change also allows to check for a power of two zone size in generic >> code. > > I think however that this checks should remain at the driver level, or > at least depend on a flag that signals that the zoned device is actually > a power of two. The block layer requires a power of two zone size / chunk size, including having a BUG_ON for that requirement blk_queue_chunk_sectors. I'd much rather have a proper check in the zone code with proper diagnostics than triggering a BUG_ON..