On Sun, Nov 3, 2019 at 8:28 AM Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx> wrote: > > Ming, > > On 11/02/2019 01:02 AM, Ming Lei wrote: > > It is reported that sysfs buffer overflow can be triggered in case > > of too many CPU cores(>841 on 4K PAGE_SIZE) when showing CPUs of > > hctx via/sys/block/$DEV/mq/$N/cpu_list. > > > > So use snprintf for avoiding the potential buffer overflow. > > > > This version doesn't change the attribute format, and simply stop > > to show CPU number if the buffer is to be overflow. > > Does it make sense to also add a print or WARN_ON in case of overflow ? Yes, it does, could you cook a patch for that? Thanks, Ming Lei