On 11/2/19 6:25 PM, Chaitanya Kulkarni wrote: > Ming, > > On 11/02/2019 01:02 AM, Ming Lei wrote: >> It is reported that sysfs buffer overflow can be triggered in case >> of too many CPU cores(>841 on 4K PAGE_SIZE) when showing CPUs of >> hctx via/sys/block/$DEV/mq/$N/cpu_list. >> >> So use snprintf for avoiding the potential buffer overflow. >> >> This version doesn't change the attribute format, and simply stop >> to show CPU number if the buffer is to be overflow. > > Does it make sense to also add a print or WARN_ON in case of overflow ? Just more noise I think, really wouldn't serve any purpose. -- Jens Axboe
