On 10/16/2019 12:32 AM, Christoph Hellwig wrote: > On Tue, Oct 15, 2019 at 05:02:45PM -0600, Revanth Rajashekar wrote: >> +static int generic_table_write_data(struct opal_dev *dev, const u64 data, u64 offset, > Please at least fix your basic coding style issues before the next > resend. Sure :)