Re: [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Revanth Rajashekar <revanth.rajashekar@xxxxxxxxx>
Subject: Re: [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 15 Oct 2019 23:32:12 -0700
Cc: linux-block@xxxxxxxxxxxxxxx, Jonathan Derrick <jonathan.derrick@xxxxxxxxx>, Scott Bauer <sbauer@xxxxxxxxxxxxxx>, Jonas Rabenstine <jonas.rabenstein@xxxxxxxxxxxxxxxxxxxxxxx>, David Kozub <zub@xxxxxxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
In-reply-to: <20191015230246.10171-3-revanth.rajashekar@intel.com>
References: <20191015230246.10171-1-revanth.rajashekar@intel.com> <20191015230246.10171-3-revanth.rajashekar@intel.com>
User-agent: Mutt/1.12.1 (2019-06-15)

On Tue, Oct 15, 2019 at 05:02:45PM -0600, Revanth Rajashekar wrote:
> +static int generic_table_write_data(struct opal_dev *dev, const u64 data, u64 offset,

Please at least fix your basic coding style issues before the next
resend.

Follow-Ups:
- Re: [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table
  - From: Rajashekar, Revanth

References:
- [PATCH v2 0/3] block: sed-opal: Generic Read/Write Opal Tables
  - From: Revanth Rajashekar
- [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table
  - From: Revanth Rajashekar

Prev by Date: Re: [PATCH v2 1/3] block: sed-opal: Expose enum opal_uid and opaluid
Next by Date: Re: [RFC PATCH 1/2] block: add support for redirecting IO completion through eBPF
Previous by thread: [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table
Next by thread: Re: [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]