Re: [PATCH 1/1] blk-mq: reuse code in blk_mq_check_inflight*()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 30, 2019 at 11:27:32AM +0300, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@xxxxxxxxx>
> 
> 1. Reuse the same walker callback for both blk_mq_in_flight() and
> blk_mq_in_flight_rw().
> 
> 2. Store inflight counters immediately in struct mq_inflight.
> It's type-safer and removes extra indirection.

You really want to split this into two patches.  Part 2 looks very
sensible to me, but I don't really see how 1 is qn equivalent
transformation right now.  Splitting it out and writing a non-trivial
changelog might help understanding it if you think it really is
equivalent as-is.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux