On Thu, Sep 26, 2019 at 1:43 AM Danil Kipnis <danil.kipnis@xxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 17, 2019 at 6:36 PM Jinpu Wang <jinpu.wang@xxxxxxxxxxxxxxx> wrote: > > > > On Sat, Sep 14, 2019 at 12:25 AM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > > > > > On 6/20/19 8:03 AM, Jack Wang wrote: > > > > + char pathname[NAME_MAX]; > > > [ ... ] > > > > + char blk_symlink_name[NAME_MAX]; > > > > > > Please allocate path names dynamically instead of hard-coding the upper > > > length for a path. > Those strings are used to name directories and files under sysfs, > which I think makes NAME_MAX a natural limitation for them. Client and > server only exchange those strings on connection establishment, not in > the IO path. We do not really need to safe 256K on a server with 1000 > devices mapped in parallel. A patch to allocate those strings makes > the code longer, introduces new error paths and in my opinion doesn't > bring any benefits. Hi Bart, We have a draft patch, but it looks ugly, after discussing in house, due to the reason Danil mentioned. we dropped the patch. Thanks, Jinpu
