Re: [PATCH v4 16/25] ibnbd: client: private header with client structs and functions

To: Jack Wang <jinpuwang@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v4 16/25] ibnbd: client: private header with client structs and functions
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 13 Sep 2019 15:25:13 -0700
Cc: axboe@xxxxxxxxx, hch@xxxxxxxxxxxxx, sagi@xxxxxxxxxxx, jgg@xxxxxxxxxxxx, dledford@xxxxxxxxxx, danil.kipnis@xxxxxxxxxxxxxxx, rpenyaev@xxxxxxx, Roman Pen <roman.penyaev@xxxxxxxxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
In-reply-to: <20190620150337.7847-17-jinpuwang@gmail.com>
References: <20190620150337.7847-1-jinpuwang@gmail.com> <20190620150337.7847-17-jinpuwang@gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 6/20/19 8:03 AM, Jack Wang wrote:

+	char			pathname[NAME_MAX];

[ ... ]
> +	char			blk_symlink_name[NAME_MAX];

Please allocate path names dynamically instead of hard-coding the upperlength for a path.


Bart.

Follow-Ups:
- Re: [PATCH v4 16/25] ibnbd: client: private header with client structs and functions
  - From: Jinpu Wang

References:
- [PATCH v4 00/25] InfiniBand Transport (IBTRS) and Network Block Device (IBNBD)
  - From: Jack Wang
- [PATCH v4 16/25] ibnbd: client: private header with client structs and functions
  - From: Jack Wang