Re: [PATCH v3 0/2] blk-mq: Avoid memory reclaim when allocating

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019/9/18 7:25, Jens Axboe wrote:
On 9/17/19 5:19 PM, Xiubo Li wrote:
On 2019/9/18 7:11, Jens Axboe wrote:
On 9/17/19 4:54 PM, Xiubo Li wrote:
On 2019/9/17 22:13, Jens Axboe wrote:
On 9/17/19 6:09 AM, xiubli@xxxxxxxxxx wrote:
From: Xiubo Li <xiubli@xxxxxxxxxx>

Changed in V2:
- Addressed the comment from Ming Lei, thanks.

Changed in V3:
- Switch to memalloc_noio_save/restore from Christoph's comment, thanks.
This now seems to be a mix of both approaches, which I don't think makes
sense at all. I think we should just stick to the gfp_t being passed in,
and defining the standard mask for init time blk-mq memory allocations.

Hmm, I might missed or misunderstand from the last thread. In this
thread with the save/store, the GFP_KERNEL is using instead. Maybe
save/store pair is not a exactly correct place or occasion to use here
as @Bart mentioned.
Just make them all gfp based please, and skip the memalloc() stuff.
Yeah, isn't the v2 thread needed here ?
It might be, I didn't look super closely at v2. I'll take a look.

Sure :-)

BRs





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux