On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote: > > Dear Satya. > Keyslot manager is a good solution for ICE. And probably no issue for FMP. > But, I think it's complicated for FMP because FMP doesn't need > any keyslot control. Hi Boojin, I think the important thing to realize here is that there are a large number of hardware devices for which the keyslot manager *is* needed. And from the upstream kernel's perspective, supporting two different schemes for supporting the inline encryption feature is more complexity than just supporting one which is general enough to support a wider variety of hardware devices. If you want somethig which is only good for the hardware platform you are charged to support, that's fine if it's only going to be in a Samsung-specific kernel. But if your goal is to get something that works upstream, especially if it requires changes in core layers of the kernel, it's important that it's general enough to support most, if not all, if the hardware devices in the industry. Regards, - Ted
