On 23/08/2019 02:15, Damien Le Moal wrote: > -static struct elevator_type *elevator_find(const char *name) > +static struct elevator_type *elevator_find(const char *name, > + unsigned long required_features) [...] > + const unsigned long elevator_features; Wouldn't it make more sens to have a defined number of bits for the features 'unsigned long' means 64 possible features on 64bit and 32 on 32 bit? Better make it explicit (u64 or u32 depending on how many features you think you'll need). Byte, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
